Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Re-add local bool has_received_time in time_system #6357

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Re-add local bool has_received_time in time_system #6357

wants to merge 1 commit into from

Conversation

ShinySapphic
Copy link
Contributor

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Time Involves time keeping and reporting labels Oct 24, 2022
alice-i-cecile
alice-i-cecile approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks for fixing this.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 24, 2022
@alice-i-cecile alice-i-cecile added this to the Bevy 0.9 milestone Oct 24, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Oct 24, 2022
@ShinySapphic
Re-add local bool has_received_time in time_system (#6357)
6aa2dce 
# Objective

- Fixes #6355 

## Solution

- Add the removed local bool from #6159
@bors
Copy link
Contributor

bors bot commented Oct 24, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Re-add local bool has_received_time in time_system [Merged by Bors] - Re-add local bool has_received_time in time_system Oct 24, 2022
@bors bors bot closed this Oct 24, 2022
@mockersf mockersf added the hacktoberfest-accepted A PR that was accepted for Hacktoberfest, an annual open source event label Oct 24, 2022
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@ShinySapphic @james7132
Re-add local bool has_received_time in time_system (bevyengine#6357)
e3b82f3 
# Objective

- Fixes bevyengine#6355 

## Solution

- Add the removed local bool from bevyengine#6159
Pietrek14 pushed a commit to Pietrek14/bevy that referenced this pull request Dec 17, 2022
@ShinySapphic @Pietrek14
Re-add local bool has_received_time in time_system (bevyengine#6357)
a88968b 
# Objective

- Fixes bevyengine#6355 

## Solution

- Add the removed local bool from bevyengine#6159
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@ShinySapphic @ItsDoot
Re-add local bool has_received_time in time_system (bevyengine#6357)
08e623c 
# Objective

- Fixes bevyengine#6355 

## Solution

- Add the removed local bool from bevyengine#6159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Time Involves time keeping and reporting C-Bug An unexpected or incorrect behavior hacktoberfest-accepted A PR that was accepted for Hacktoberfest, an annual open source event S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
Bevy 0.9
Development

Successfully merging this pull request may close these issues.

warning log about time when starting an example
3 participants
@ShinySapphic @alice-i-cecile @mockersf