Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - can get the settings of a plugin from the app #6372

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - can get the settings of a plugin from the app #6372

wants to merge 3 commits into from

Conversation

mockersf
Copy link
Member

Objective

  • Make the settings of plugins readable during app building

Solution

  • Added a vector of added plugins to the app. Their settings can be accessed as read only

@mockersf mockersf mentioned this pull request Oct 26, 2022
Closed
@mockersf mockersf added C-Usability A simple quality-of-life change that makes Bevy easier to use A-App Bevy apps and plugins labels Oct 26, 2022
@alice-i-cecile alice-i-cecile added this to the Bevy 0.9 milestone Oct 26, 2022
alice-i-cecile
alice-i-cecile requested changes Oct 26, 2022
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc improvements for you, then LGTM. I'm excited to see plugins turn into a fully powered feature.

Also you need to fix clippy :P

mockersf and others added 2 commits October 26, 2022 19:27
@mockersf
clippy
9631f0a
@mockersf @alice-i-cecile
doc!
13485ed 
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
@MDeiml
Copy link
Contributor

MDeiml commented Oct 26, 2022

Next step would be to actually make every plugin check if all it's dependencies are satisfied. That way developers would get a sensible error when they add plugins in the wrong order.

alice-i-cecile
alice-i-cecile approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot pushed a commit that referenced this pull request Oct 26, 2022
@mockersf
can get the settings of a plugin from the app (#6372)
7671dde 
# Objective

- Make the settings of plugins readable during app building

## Solution

- Added a vector of added plugins to the app. Their settings can be accessed as read only
@bors
Copy link
Contributor

bors bot commented Oct 26, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title can get the settings of a plugin from the app [Merged by Bors] - can get the settings of a plugin from the app Oct 26, 2022
@bors bors bot closed this Oct 26, 2022
@mockersf mockersf added the hacktoberfest-accepted A PR that was accepted for Hacktoberfest, an annual open source event label Oct 27, 2022
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@mockersf @james7132
can get the settings of a plugin from the app (bevyengine#6372)
1fa37b5 
# Objective

- Make the settings of plugins readable during app building

## Solution

- Added a vector of added plugins to the app. Their settings can be accessed as read only
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
can get the settings of a plugin from the app (bevyengine#6372)
607e0c4 
# Objective

- Make the settings of plugins readable during app building

## Solution

- Added a vector of added plugins to the app. Their settings can be accessed as read only
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@MDeiml MDeiml MDeiml approved these changes

Assignees
No one assigned
Labels
A-App Bevy apps and plugins C-Usability A simple quality-of-life change that makes Bevy easier to use hacktoberfest-accepted A PR that was accepted for Hacktoberfest, an annual open source event
Projects
None yet
Milestone
Bevy 0.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mockersf @MDeiml @alice-i-cecile