Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - do not set cursor grab on window creation if not asked for #6381

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - do not set cursor grab on window creation if not asked for #6381

wants to merge 1 commit into from

Conversation

mockersf
Copy link
Member

Objective

  • Bevy main crashs on Safari mobile
  • On Safari mobile, calling winit_window.set_cursor_grab(true) fails as the API is not implemented (as there is no cursor on Safari mobile, the api doesn't make sense there). I don't know about other mobile browsers

Solution

@mockersf mockersf added A-Windowing Platform-agnostic interface layer to run your app in O-Web Specific to web (WASM) builds C-Bug An unexpected or incorrect behavior C-Regression Functionality that used to work but no longer does. Add a test for this! labels Oct 26, 2022
@mockersf mockersf added this to the Bevy 0.9 milestone Oct 26, 2022
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 27, 2022
@alice-i-cecile
Copy link
Member

It looks like this panic is actually our fault: winit returns a Result, as they should.

bors r+

bors bot pushed a commit that referenced this pull request Oct 31, 2022
@mockersf
do not set cursor grab on window creation if not asked for (#6381)
ca82fa8 
# Objective

- Bevy main crashs on Safari mobile
- On Safari mobile, calling winit_window.set_cursor_grab(true) fails as the API is not implemented (as there is no cursor on Safari mobile, the api doesn't make sense there). I don't know about other mobile browsers

## Solution

- Do not call the api to release cursor grab on window creation, as the cursor is not grabbed anyway at this point
- This is #3617 which was lost in #6218
@bors
Copy link
Contributor

bors bot commented Oct 31, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title do not set cursor grab on window creation if not asked for [Merged by Bors] - do not set cursor grab on window creation if not asked for Oct 31, 2022
@bors bors bot closed this Oct 31, 2022
@mockersf mockersf added the hacktoberfest-accepted A PR that was accepted for Hacktoberfest, an annual open source event label Oct 31, 2022
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
do not set cursor grab on window creation if not asked for (bevyengin…
df43a1f 
…e#6381)

# Objective

- Bevy main crashs on Safari mobile
- On Safari mobile, calling winit_window.set_cursor_grab(true) fails as the API is not implemented (as there is no cursor on Safari mobile, the api doesn't make sense there). I don't know about other mobile browsers

## Solution

- Do not call the api to release cursor grab on window creation, as the cursor is not grabbed anyway at this point
- This is bevyengine#3617 which was lost in bevyengine#6218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@VitalyAnkh VitalyAnkh VitalyAnkh approved these changes

@irate-devil irate-devil irate-devil approved these changes

Assignees
No one assigned
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Bug An unexpected or incorrect behavior C-Regression Functionality that used to work but no longer does. Add a test for this! hacktoberfest-accepted A PR that was accepted for Hacktoberfest, an annual open source event O-Web Specific to web (WASM) builds S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
Bevy 0.9
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mockersf @alice-i-cecile @VitalyAnkh @irate-devil