Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add FromReflect for Timer #6422

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Add FromReflect for Timer #6422

wants to merge 1 commit into from

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Oct 30, 2022

Objective

  • Time have Reflect, but doesn't have FromReflect.

Solution

  • Add it for Timer, Stopwatch and TimerMode.

Changelog

Added

  • FromReflect derive for Timer, Stopwatch and TimerMode.

@alice-i-cecile alice-i-cecile added C-Usability A simple quality-of-life change that makes Bevy easier to use A-Time Involves time keeping and reporting S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it hacktoberfest-accepted A PR that was accepted for Hacktoberfest, an annual open source event and removed hacktoberfest-accepted A PR that was accepted for Hacktoberfest, an annual open source event labels Oct 30, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Oct 30, 2022
@Shatur
Add FromReflect for Timer (#6422)
7540328 
# Objective

- Time have `Reflect`, but doesn't have `FromReflect`.

## Solution

- Add it for `Timer`, `Stopwatch` and `TimerMode`.

---

## Changelog

### Added

* `FromReflect` derive for `Timer`, `Stopwatch` and `TimerMode`.
@bors
Copy link
Contributor

bors bot commented Oct 30, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add FromReflect for Timer [Merged by Bors] - Add FromReflect for Timer Oct 30, 2022
@bors bors bot closed this Oct 30, 2022
@mockersf mockersf added the hacktoberfest-accepted A PR that was accepted for Hacktoberfest, an annual open source event label Oct 30, 2022
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@Shatur @ItsDoot
Add FromReflect for Timer (bevyengine#6422)
a069186 
# Objective

- Time have `Reflect`, but doesn't have `FromReflect`.

## Solution

- Add it for `Timer`, `Stopwatch` and `TimerMode`.

---

## Changelog

### Added

* `FromReflect` derive for `Timer`, `Stopwatch` and `TimerMode`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irate-devil irate-devil irate-devil approved these changes

@MrGVSV MrGVSV MrGVSV approved these changes

Assignees
No one assigned
Labels
A-Time Involves time keeping and reporting C-Usability A simple quality-of-life change that makes Bevy easier to use hacktoberfest-accepted A PR that was accepted for Hacktoberfest, an annual open source event S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Reflection
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Shatur @alice-i-cecile @irate-devil @MrGVSV @mockersf