Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - add ReflectDefault to std types #6429

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - add ReflectDefault to std types #6429

wants to merge 2 commits into from

Conversation

jakobhellermann
Copy link
Contributor

Objective

  • ReflectDefault can be used to create default values for reflected types
  • std primitives that are Default-constructable should register ReflectDefault

Solution

  • register ReflectDefault

@jakobhellermann jakobhellermann added C-Enhancement A new feature A-Reflection Runtime information about types labels Oct 31, 2022
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 31, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Oct 31, 2022
@jakobhellermann
add ReflectDefault to std types (#6429)
55b3cb0 
# Objective

- `ReflectDefault` can be used to create default values for reflected types
- `std` primitives that are `Default`-constructable should register `ReflectDefault`

## Solution

- register `ReflectDefault`
@bors
Copy link
Contributor

bors bot commented Oct 31, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title add ReflectDefault to std types [Merged by Bors] - add ReflectDefault to std types Oct 31, 2022
@bors bors bot closed this Oct 31, 2022
@jakobhellermann jakobhellermann deleted the reflect-default-std branch October 31, 2022 16:52
@mockersf mockersf added the hacktoberfest-accepted A PR that was accepted for Hacktoberfest, an annual open source event label Oct 31, 2022
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@jakobhellermann @ItsDoot
add ReflectDefault to std types (bevyengine#6429)
2cef2fe 
# Objective

- `ReflectDefault` can be used to create default values for reflected types
- `std` primitives that are `Default`-constructable should register `ReflectDefault`

## Solution

- register `ReflectDefault`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Reflection Runtime information about types C-Enhancement A new feature hacktoberfest-accepted A PR that was accepted for Hacktoberfest, an annual open source event S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jakobhellermann @alice-i-cecile @mockersf