[Merged by Bors] - Add is_finished to Task<T>
#6444
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james7132
approved these changes
Nov 2, 2022
james7132
added
C-Enhancement
alice-i-cecile
added
C-Usability
crates/bevy_tasks/src/task.rs
Outdated
|
|
||
| /// Returns `true` if the current task is finished. | ||
| /// | ||
| /// Note that in a multithreaded environment, this task can change finish immediately after calling this function. |
There was a problem hiding this comment.
"can change finish"? This is ungrammatical, but I can't quite figure out what's intended to give you a direct suggestion :)
crates/bevy_tasks/src/task.rs
Outdated
|
|
||
| /// Returns `true` if the current task is finished. | ||
| /// | ||
| /// Note that in a multithreaded environment, this task can change finish immediately after calling this function. |
There was a problem hiding this comment.
I'd like to see a sentence comparing this to polling, and explaining why you might want one vs the other.
alice-i-cecile
requested changes
Nov 2, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
bors bot
pushed a commit
that referenced
this pull request
Nov 2, 2022
# Objective In some scenarios it can be useful to check if a task has been finished without polling it. I added a function called `is_finished` to check if a task has been finished. ## Solution Since `async_task` supports it out of the box, it is just a simple wrapper function. ---
bors
bot
changed the title
is_finished to Task<T>is_finished to Task<T>
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective In some scenarios it can be useful to check if a task has been finished without polling it. I added a function called `is_finished` to check if a task has been finished. ## Solution Since `async_task` supports it out of the box, it is just a simple wrapper function. ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
In some scenarios it can be useful to check if a task has been finished without polling it. I added a function called
is_finishedto check if a task has been finished.Solution
Since
async_tasksupports it out of the box, it is just a simple wrapper function.