[Merged by Bors] - Add CameraRenderGraph::set #6470
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good job. I use the pathtracer and I really need this Camera set. I suggest to merge it into 0.9 |
irate-devil
approved these changes
Nov 4, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 5, 2022
# Objective Some render plugins, like [bevy-hikari](https://github.com/cryscan/bevy-hikari) require to set `CameraRenderGraph`. In order to switch between render graphs I need to insert a new `CameraRenderGraph` component. It's not very ergonomic. ## Solution Add `CameraRenderGraph::set` like in [Name](https://docs.rs/bevy/latest/bevy/core/struct.Name.html). --- ## Changelog ### Added - `CameraRenderGraph::set`.
james7132
added
C-Enhancement
|
Build failed:
|
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Nov 6, 2022
# Objective Some render plugins, like [bevy-hikari](https://github.com/cryscan/bevy-hikari) require to set `CameraRenderGraph`. In order to switch between render graphs I need to insert a new `CameraRenderGraph` component. It's not very ergonomic. ## Solution Add `CameraRenderGraph::set` like in [Name](https://docs.rs/bevy/latest/bevy/core/struct.Name.html). --- ## Changelog ### Added - `CameraRenderGraph::set`.
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Some render plugins, like [bevy-hikari](https://github.com/cryscan/bevy-hikari) require to set `CameraRenderGraph`. In order to switch between render graphs I need to insert a new `CameraRenderGraph` component. It's not very ergonomic. ## Solution Add `CameraRenderGraph::set` like in [Name](https://docs.rs/bevy/latest/bevy/core/struct.Name.html). --- ## Changelog ### Added - `CameraRenderGraph::set`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Some render plugins, like bevy-hikari require to set
CameraRenderGraph. In order to switch between render graphs I need to insert a newCameraRenderGraphcomponent. It's not very ergonomic.Solution
Add
CameraRenderGraph::setlike in Name.Changelog
Added
CameraRenderGraph::set.