[Merged by Bors] - Cleaning up NodeBundle, and some slight UI module re-organization #6473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mera config stuff from the pre-made UI node bundles.
alice-i-cecile
approved these changes
Nov 5, 2022
alice-i-cecile
added
A-UI
|
This is technically a breaking change but I don't think it needs a migration guide. |
IceSentry
approved these changes
Nov 5, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
Weibye
approved these changes
Nov 5, 2022
|
@bzm3r those doc links are genuinely broken :) |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 5, 2022
) # Objective `NodeBundle` contains an `image` field, which can be misleading, because if you do supply an image there, nothing will be shown to screen. You need to use an `ImageBundle` instead. ## Solution * `image` (`UiImage`) field is removed from `NodeBundle`, * extraction stage queries now make an optional query for `UiImage`, if one is not found, use the image handle that is used as a default by `UiImage`: https://github.com/bevyengine/bevy/blob/c019a60b39c5683656025bc9d24a02744aa59dea/crates/bevy_ui/src/ui_node.rs#L464 * touching up docs for `NodeBundle` to help guide what `NodeBundle` should be used for * renamed `entity.rs` to `node_bundle.rs` as that gives more of a hint regarding the module's purpose * separating `camera_config` stuff from the pre-made UI node bundles so that `node_bundle.rs` makes more sense as a module name.
bors
bot
changed the title
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…vyengine#6473) # Objective `NodeBundle` contains an `image` field, which can be misleading, because if you do supply an image there, nothing will be shown to screen. You need to use an `ImageBundle` instead. ## Solution * `image` (`UiImage`) field is removed from `NodeBundle`, * extraction stage queries now make an optional query for `UiImage`, if one is not found, use the image handle that is used as a default by `UiImage`: https://github.com/bevyengine/bevy/blob/c019a60b39c5683656025bc9d24a02744aa59dea/crates/bevy_ui/src/ui_node.rs#L464 * touching up docs for `NodeBundle` to help guide what `NodeBundle` should be used for * renamed `entity.rs` to `node_bundle.rs` as that gives more of a hint regarding the module's purpose * separating `camera_config` stuff from the pre-made UI node bundles so that `node_bundle.rs` makes more sense as a module name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
NodeBundlecontains animagefield, which can be misleading, because if you do supply an image there, nothing will be shown to screen. You need to use anImageBundleinstead.Solution
image(UiImage) field is removed fromNodeBundle,UiImage, if one is not found, use the image handle that is used as a default byUiImage:bevy/crates/bevy_ui/src/ui_node.rs
Line 464 in c019a60
NodeBundleto help guide whatNodeBundleshould be used forentity.rstonode_bundle.rsas that gives more of a hint regarding the module's purposecamera_configstuff from the pre-made UI node bundles so thatnode_bundle.rsmakes more sense as a module name.