Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Update concurrent-queue to 2.0 #6538

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Update concurrent-queue to 2.0 #6538

wants to merge 2 commits into from

Conversation

irate-devil
Copy link
Contributor

@irate-devil irate-devil commented Nov 10, 2022 •
edited by bors bot

No description provided.

@mockersf
Copy link
Member

You should ignore the oldest version, not the most recent.

In this specific case, concurrent-queue has been updated to 2.0 2 days ago: https://github.com/smol-rs/concurrent-queue/releases/tag/v2.0.0
The crate depending on the older version, async-channel, has already been updated but not yet published: smol-rs/async-channel@530a2ed

Before adding an ignore, I would rather wait a few days for an update

@irate-devil irate-devil force-pushed the skip-deny-concurrent-queue-2.0.0 branch from 2077d99 to 415289f Compare November 10, 2022 17:26
@irate-devil irate-devil changed the title Fix check-bans CI failure Update concurrent-queue to 2.0 Nov 10, 2022
@irate-devil
Copy link
Contributor Author

irate-devil commented Nov 10, 2022 •
edited

I misinterpreted the other skip entries as I was thinking about it :V

This PR now updates our dependency on concurrent-queue to 2.0.

edit: Wait... that means CI will now fail here, doesn't it D:

@alice-i-cecile alice-i-cecile added C-Dependencies A change to the crates that Bevy depends on A-Build-System Related to build systems or continuous integration labels Nov 10, 2022
@yodaldevoid yodaldevoid mentioned this pull request Nov 10, 2022
Open
@mockersf mockersf mentioned this pull request Nov 14, 2022
Closed
@yodaldevoid
Copy link

yodaldevoid commented Nov 30, 2022 •
edited

async-channel version 1.8.0 has been published using concurrent-queue 2.0.

async-channel should be specified wit 1.5.0 as a minimum version and async-channel with 1.8.0 with the upgrade to concurrent-queue 2.0.0.

@james7132
Copy link
Member

The async_task version was specifically pinned in #6509, as we're reliant on one of the APIs exposed on it.

@mockersf
Copy link
Member

mockersf commented Dec 13, 2022 •
edited

@devil-ira could you re-add async-task? This should be good to merge after

@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 13, 2022
@mockersf
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Dec 13, 2022
@irate-devil
Update concurrent-queue to 2.0 (#6538)
b7d6ee8 
Co-authored-by: devil-ira <justthecooldude@gmail.com>
@bors
Copy link
Contributor

bors bot commented Dec 13, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Update concurrent-queue to 2.0 [Merged by Bors] - Update concurrent-queue to 2.0 Dec 13, 2022
@bors bors bot closed this Dec 13, 2022
james7132 pushed a commit to james7132/bevy that referenced this pull request Dec 16, 2022
@irate-devil @james7132
Update concurrent-queue to 2.0 (bevyengine#6538)
83757c4 
Co-authored-by: devil-ira <justthecooldude@gmail.com>
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@irate-devil @alradish
Update concurrent-queue to 2.0 (bevyengine#6538)
382d910 
Co-authored-by: devil-ira <justthecooldude@gmail.com>
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@irate-devil @ItsDoot
Update concurrent-queue to 2.0 (bevyengine#6538)
8f56ce8 
Co-authored-by: devil-ira <justthecooldude@gmail.com>
@irate-devil irate-devil deleted the skip-deny-concurrent-queue-2.0.0 branch March 13, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Dependencies A change to the crates that Bevy depends on S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@irate-devil @mockersf @yodaldevoid @james7132 @alice-i-cecile