Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Rename EntityId to EntityIndex #6732

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Rename EntityId to EntityIndex #6732

wants to merge 1 commit into from

Conversation

irate-devil
Copy link
Contributor

@irate-devil irate-devil commented Nov 22, 2022 •
edited

Continuation of #6107

@irate-devil irate-devil changed the title Rename EntityId to e Rename EntityId to EntityIndex Nov 22, 2022
@irate-devil irate-devil marked this pull request as ready for review November 22, 2022 19:29
@james7132 james7132 added C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it A-ECS Entities, components, systems, and events labels Nov 22, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Nov 22, 2022
@irate-devil
Rename EntityId to EntityIndex (#6732)
a1607b8 
Continuation of #6107

Co-authored-by: devil-ira <justthecooldude@gmail.com>
@bors
Copy link
Contributor

bors bot commented Nov 22, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Rename EntityId to EntityIndex [Merged by Bors] - Rename EntityId to EntityIndex Nov 22, 2022
@bors bors bot closed this Nov 22, 2022
@irate-devil irate-devil deleted the rename-entityid-to-entityindex branch November 24, 2022 11:22
taiyoungjang pushed a commit to taiyoungjang/bevy that referenced this pull request Dec 15, 2022
@irate-devil @taiyoungjang
Rename EntityId to EntityIndex (bevyengine#6732)
e105fb1 
Continuation of bevyengine#6107

Co-authored-by: devil-ira <justthecooldude@gmail.com>
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@irate-devil @alradish
Rename EntityId to EntityIndex (bevyengine#6732)
9add320 
Continuation of bevyengine#6107

Co-authored-by: devil-ira <justthecooldude@gmail.com>
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@irate-devil @ItsDoot
Rename EntityId to EntityIndex (bevyengine#6732)
e1a667c 
Continuation of bevyengine#6107

Co-authored-by: devil-ira <justthecooldude@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@Carter0 Carter0 Carter0 approved these changes

@MrGVSV MrGVSV MrGVSV approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@irate-devil @alice-i-cecile @Carter0 @MrGVSV @james7132