Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for ser/de reflected unit structs #6735

Closed
wants to merge 1 commit into from
Closed

Add tests for ser/de reflected unit structs #6735

wants to merge 1 commit into from

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Nov 22, 2022

Objective

  • Reflected unit structs fails to deserialize with no field at index 0 on struct <name>

Solution

  • Test this case.
  • Fix it.

Changelog

Fixed

  • Deserialization for reflected unit structs.

@Shatur Shatur requested a review from MrGVSV November 22, 2022 23:30
@alice-i-cecile alice-i-cecile added this to the 0.9.1 milestone Nov 22, 2022
@alice-i-cecile alice-i-cecile added A-Reflection Runtime information about types C-Bug An unexpected or incorrect behavior labels Nov 22, 2022
@alice-i-cecile
Copy link
Member

alice-i-cecile commented Nov 22, 2022 •
edited

Hopefully fixes #6713.

@Shatur
Copy link
Contributor Author

Shatur commented Nov 22, 2022

Duplicate of #6722, I somehow missed it 😄

@Shatur Shatur closed this Nov 22, 2022
@Shatur Shatur deleted the reflect-unit-structs branch November 22, 2022 23:34
@Shatur Shatur removed this from the 0.9.1 milestone Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrGVSV MrGVSV Awaiting requested review from MrGVSV

Assignees
No one assigned
Labels
A-Reflection Runtime information about types C-Bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Shatur @alice-i-cecile