Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix spot dir nan again #7176

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - fix spot dir nan again #7176

wants to merge 1 commit into from

Conversation

robtfm
Copy link
Contributor

@robtfm robtfm commented Jan 12, 2023

Objective

fix error with shadow shader's spotlight direction calculation when direction.y ~= 0
fixes #7152

Solution

same as #6167: in shadows.wgsl, clamp 1-x^2-z^2 to >= 0 so that we can safely sqrt it

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen C-Regression Functionality that used to work but no longer does. Add a test for this! S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Jan 12, 2023
@mockersf
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jan 13, 2023
@robtfm
fix spot dir nan again (#7176)
15c3bda 
# Objective

fix error with shadow shader's spotlight direction calculation when direction.y ~= 0
fixes #7152

## Solution

same as #6167: in shadows.wgsl, clamp 1-x^2-z^2 to >= 0 so that we can safely sqrt it
@bors
Copy link
Contributor

bors bot commented Jan 13, 2023

Build failed:

@mockersf
Copy link
Member

bors retry

bors bot pushed a commit that referenced this pull request Jan 13, 2023
@robtfm
fix spot dir nan again (#7176)
bc12e61 
# Objective

fix error with shadow shader's spotlight direction calculation when direction.y ~= 0
fixes #7152

## Solution

same as #6167: in shadows.wgsl, clamp 1-x^2-z^2 to >= 0 so that we can safely sqrt it
@bors
Copy link
Contributor

bors bot commented Jan 13, 2023

Build failed:

@alice-i-cecile
Copy link
Member

bors retry

bors bot pushed a commit that referenced this pull request Jan 13, 2023
@robtfm
fix spot dir nan again (#7176)
b6ac3d7 
# Objective

fix error with shadow shader's spotlight direction calculation when direction.y ~= 0
fixes #7152

## Solution

same as #6167: in shadows.wgsl, clamp 1-x^2-z^2 to >= 0 so that we can safely sqrt it
@bors
Copy link
Contributor

bors bot commented Jan 13, 2023

Build failed:

@mockersf
Copy link
Member

ubuntu package mirrors are not feeling good right now...

@mockersf
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jan 13, 2023
@robtfm
fix spot dir nan again (#7176)
8cc7d1a 
# Objective

fix error with shadow shader's spotlight direction calculation when direction.y ~= 0
fixes #7152

## Solution

same as #6167: in shadows.wgsl, clamp 1-x^2-z^2 to >= 0 so that we can safely sqrt it
@bors
Copy link
Contributor

bors bot commented Jan 13, 2023

Build failed:

@mockersf
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jan 13, 2023
@robtfm
fix spot dir nan again (#7176)
0af8e1c 
# Objective

fix error with shadow shader's spotlight direction calculation when direction.y ~= 0
fixes #7152

## Solution

same as #6167: in shadows.wgsl, clamp 1-x^2-z^2 to >= 0 so that we can safely sqrt it
@bors
Copy link
Contributor

bors bot commented Jan 13, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title fix spot dir nan again [Merged by Bors] - fix spot dir nan again Jan 13, 2023
@bors bors bot closed this Jan 13, 2023
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@robtfm @alradish
fix spot dir nan again (bevyengine#7176)
84332fe 
# Objective

fix error with shadow shader's spotlight direction calculation when direction.y ~= 0
fixes bevyengine#7152

## Solution

same as bevyengine#6167: in shadows.wgsl, clamp 1-x^2-z^2 to >= 0 so that we can safely sqrt it
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@robtfm @ItsDoot
fix spot dir nan again (bevyengine#7176)
de6fcdc 
# Objective

fix error with shadow shader's spotlight direction calculation when direction.y ~= 0
fixes bevyengine#7152

## Solution

same as bevyengine#6167: in shadows.wgsl, clamp 1-x^2-z^2 to >= 0 so that we can safely sqrt it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior C-Regression Functionality that used to work but no longer does. Add a test for this! S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Moving Spotlight with shadows_enabled not shining
3 participants
@robtfm @mockersf @alice-i-cecile