Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix UI corruption for AMD gpus with Vulkan (#9169)" #9237

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

Elabajaba
Copy link
Contributor

Objective

Fixes #9234

re-breaks: The issues that were linked in #9169

Solution

Revert the PR that broke tonemapping/postprocessing/etc.

Any passes that are post msaa resolve need to use the main textures, not the msaa texture.

Changelog

Idk what to put here since it's a revert.

@mockersf
Copy link
Member

Any passes that are post msaa resolve need to use the main textures, not the msaa texture.

Could we try moving UI earlier?

@Elabajaba
Copy link
Contributor Author

Elabajaba commented Jul 22, 2023

Any passes that are post msaa resolve need to use the main textures, not the msaa texture.

Could we try moving UI earlier?

I don't think so? Afaik ui shouldn't be before post processing, and you need to do msaa resolve before you do post processing.

@mockersf
Copy link
Member

It seems other game engines can render UI either as overlay, same as Bevy does, and this is after post processing, or as camera, and then the user can choose where and which post processing effects will be applied to UI.

As Bevy UI is overlay, it makes sense to revert that change.

@mockersf mockersf added A-Rendering Drawing game state to the screen A-UI Graphical user interfaces, styles, layouts, and widgets labels Jul 23, 2023
@superdump superdump added this pull request to the merge queue Jul 25, 2023
Merged via the queue into bevyengine:main with commit 774fb56 Jul 25, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen A-UI Graphical user interfaces, styles, layouts, and widgets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken post processing after using MSAA for UI pass
4 participants