Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connectors): fixes MGDCTRS-1056, renamed mas-sso-* addon params to sso-* #1092

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dhirajsb
Copy link
Contributor

@dhirajsb dhirajsb commented Jun 9, 2022

Description

fixes MGDCTRS-1056, renamed mas-sso-* addon params to sso-*

Verification Steps

CI integration tests must continue to pass.

Checklist (Definition of Done)

  • All acceptance criteria specified in JIRA have been completed
  • Unit and integration tests added that prove the fix is effective or the feature works (tested against emulated and non-emulated OCM environment)
  • Documentation added for the feature
  • CI and all relevant tests are passing
  • Code Review completed
    - [ ] Verified independently by reviewer
  • All PR comments are resolved either by addressing them or creating follow up tasks
    - [ ] Required metrics/dashboards/alerts have been added (or PR created).
    - [ ] Required Standard Operating Procedure (SOP) is added.
  • JIRA has been created for changes required on the client side

@dhirajsb dhirajsb marked this pull request as draft June 9, 2022 16:10
@dhirajsb
Copy link
Contributor Author

dhirajsb commented Jun 9, 2022

@lburgazzoli this is a minor change on the fleet manager side, but it also needs corresponding changes to the data plane and addon.

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #1092 (1628f4d) into main (0ecff40) will decrease coverage by 5.68%.
The diff coverage is n/a.

❗ Current head 1628f4d differs from pull request most recent head d8e561f. Consider uploading reports for the commit d8e561f to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1092      +/-   ##
==========================================
- Coverage   80.11%   74.42%   -5.69%     
==========================================
  Files         129      127       -2     
  Lines       10946    11015      +69     
==========================================
- Hits         8769     8198     -571     
- Misses       1816     2452     +636     
- Partials      361      365       +4     
Flag Coverage Δ
unittests 74.42% <ø> (-5.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ternal/kafka/internal/handlers/data_plane_kafka.go 0.00% <0.00%> (-100.00%) ⬇️
...al/kafka/internal/handlers/kafka_instance_types.go 0.00% <0.00%> (-100.00%) ⬇️
internal/kafka/internal/handlers/kafka.go 1.50% <0.00%> (-98.50%) ⬇️
...rnal/kafka/internal/handlers/data_plane_cluster.go 0.00% <0.00%> (-94.55%) ⬇️
...ternal/kafka/internal/handlers/service_accounts.go 0.00% <0.00%> (-93.67%) ⬇️
internal/kafka/internal/handlers/metrics.go 0.00% <0.00%> (-91.90%) ⬇️
pkg/quota_management/organisation.go 57.14% <0.00%> (-42.86%) ⬇️
internal/kafka/internal/handlers/validation.go 43.28% <0.00%> (-42.66%) ⬇️
pkg/quota_management/account.go 92.30% <0.00%> (-7.70%) ⬇️
pkg/services/sso/keycloak_service_builder.go 75.00% <0.00%> (-4.17%) ⬇️
... and 31 more

@dhirajsb
Copy link
Contributor Author

dhirajsb commented Jun 9, 2022

@abkieling, @rinaldodev this will require changes in the addon.

@dhirajsb dhirajsb added the do-not-merge A Pull Request with this label should not be merged: it might be due to pending questions, feedback label Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connector do-not-merge A Pull Request with this label should not be merged: it might be due to pending questions, feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant