Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update grace period days config description #1549

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JameelB
Copy link
Contributor

@JameelB JameelB commented Feb 7, 2023

Description

grace_period_days can apply to any instance types/billing model, not just those that can be promoted. e.g. if a subscription expires in ams, we want to allow users to renew their subscription before deleting their Kafka instances.

Verification Steps

  1. Doc changes reviewed

Checklist (Definition of Done)

  • All acceptance criteria specified in JIRA have been completed
  • Unit and integration tests added that prove the fix is effective or the feature works (tested against emulated and non-emulated OCM environment)
  • Documentation added for the feature
  • CI and all relevant tests are passing
  • Code Review completed
  • Verified independently by reviewer
  • All PR comments are resolved either by addressing them or creating follow up tasks
  • Required metrics/dashboards/alerts have been added (or PR created).
  • Required Standard Operating Procedure (SOP) is added.
  • JIRA has been created for changes required on the client side

grace_period_days can apply to any instance types/billing model, not just those that can be promoted.
e.g. if a subscription expires in ams, we want to allow users to renew their subscription before deleting
their Kafka instances.
@JameelB JameelB requested a review from a team as a code owner February 7, 2023 11:02
@github-actions github-actions bot added the kafka label Feb 7, 2023
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #1549 (70738b0) into main (8c00047) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1549   +/-   ##
=======================================
  Coverage   82.78%   82.78%           
=======================================
  Files         154      154           
  Lines       14196    14196           
=======================================
  Hits        11752    11752           
  Misses       2025     2025           
  Partials      419      419           
Flag Coverage Δ
unittests 82.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@JameelB JameelB added the do-not-merge A Pull Request with this label should not be merged: it might be due to pending questions, feedback label Feb 7, 2023
@JameelB JameelB marked this pull request as draft February 7, 2023 12:10
@miguelsorianod
Copy link
Contributor

This was pending reply from BU through other channels

@miguelsorianod
Copy link
Contributor

From this, we were pending some answers from BU. What's the current state of this? @JameelB @ziccardi

@ziccardi
Copy link
Contributor

From this, we were pending some answers from BU. What's the current state of this? @JameelB @ziccardi

Still didn't receive an answer to the JIRA. I will push it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge A Pull Request with this label should not be merged: it might be due to pending questions, feedback kafka
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants