Skip to content
This repository has been archived by the owner on Jan 11, 2024. It is now read-only.

fix: css overrides that are happening in clouddot #459

Merged
merged 5 commits into from
Apr 23, 2021
Merged

fix: css overrides that are happening in clouddot #459

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
254243c
quick changes
christiemolloy Apr 22, 2021
26e2819
fix select borders
christiemolloy Apr 22, 2021
d691298
fixes for select
christiemolloy Apr 22, 2021
ecd6202
fix: add css to openshift streams
christiemolloy Apr 22, 2021
41dc328
add comment inline
christiemolloy Apr 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/app/app.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ html, body, #root {
}

.pf-c-select__toggle:before {
border-top: var(--pf-c-select__toggle--before--BorderTopWidth) solid var(--pf-c-select__toggle--before--BorderTopColor);
border-right: var(--pf-c-select__toggle--before--BorderRightWidth) solid var(--pf-c-select__toggle--before--BorderRightColor);
border-bottom: var(--pf-c-select__toggle--before--BorderBottomWidth) solid var(--pf-c-select__toggle--before--BorderBottomColor);
border-left: var(--pf-c-select__toggle--before--BorderLeftWidth) solid var(--pf-c-select__toggle--before--BorderLeftColor);
border-top: 1px solid var(--pf-c-select__toggle--before--BorderTopColor);
border-right: 1px solid var(--pf-c-select__toggle--before--BorderRightColor);
border-bottom: 1px solid var(--pf-c-select__toggle--before--BorderBottomColor);
border-left: 1px solid var(--pf-c-select__toggle--before--BorderLeftColor);
}
4 changes: 4 additions & 0 deletions src/app/common/MASGenerateCredentialsModal/MASGenerateCredentialsModal.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
.mk--generate-credential__empty-state--input-group {
white-space: nowrap;
}

.pf-u-w-100 {
width: 100%;
}
2 changes: 1 addition & 1 deletion src/app/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import * as React from 'react';
import "@patternfly/patternfly/patternfly.min.css";
import "@patternfly/patternfly/utilities/Accessibility/accessibility.css";
import "@patternfly/patternfly/utilities/Spacing/spacing.css";
import "@patternfly/patternfly/utilities/Sizing/sizing.css";
import "@patternfly/patternfly/utilities/Spacing/spacing.css";
import { BrowserRouter as Router } from 'react-router-dom';
import { AppLayout } from '@app/AppLayout/AppLayout';
import { AppRoutes } from '@app/routes';
Expand Down
7 changes: 7 additions & 0 deletions src/app/modules/OpenshiftStreams/OpenshiftStreams.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,10 @@
font-weight: var(--pf-global--FontWeight--semi-bold);
--pf-c-button--m-link--Color: var(--pf-global--Color--100);
}

.pf-c-select__toggle:before {
border-top: 1px solid var(--pf-c-select__toggle--before--BorderTopColor);
border-right: 1px solid var(--pf-c-select__toggle--before--BorderRightColor);
border-bottom: 1px solid var(--pf-c-select__toggle--before--BorderBottomColor);
border-left: 1px solid var(--pf-c-select__toggle--before--BorderLeftColor);
}
7 changes: 7 additions & 0 deletions src/app/modules/OpenshiftStreams/components/StreamsTableView/StreamsToolbar.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,10 @@
.pf-c-chip__text {
--pf-c-chip__text--MaxWidth: 35ch;
}

.pf-c-select__toggle:before {
border-top: 1px solid var(--pf-c-select__toggle--before--BorderTopColor);
border-right: 1px solid var(--pf-c-select__toggle--before--BorderRightColor);
border-bottom: 1px solid var(--pf-c-select__toggle--before--BorderBottomColor);
border-left: 1px solid var(--pf-c-select__toggle--before--BorderLeftColor);
}
6 changes: 5 additions & 1 deletion webpack.prod.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@ module.exports = merge(common('production', { mode: "production" }), {
optimization: {
minimizer: [
new TerserJSPlugin({}),
new OptimizeCSSAssetsPlugin({})
new OptimizeCSSAssetsPlugin({
cssProcessorPluginOptions: {
preset: ['default', { mergeLonghand: false }]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was one of the suggestions Zack mentioned for the bug in the PF select patternfly/patternfly-react#5650 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment inline so that we remember why we put it there...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

}
})
],
},
output: {
Expand Down