Update action to use node20 #134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bflad
reviewed
May 7, 2024
There was a problem hiding this comment.
Thank you for working on this, @breathingdust!
At the very least, we'll also need to bump the testing workflow in .github/workflows/test.yml to use actions/reusable-workflows commit 5e63e7aef083769958fc026fe8eea0241c0eb444 so it uses NodeJS 20 (or explicitly pass in node-version: "20.x")
|
I also wouldn't be surprised if check-dist starts failing on NodeJS 20 -- running |
Co-authored-by: Brian Flad <bflad417@gmail.com>
|
@breathingdust not sure why but rebuilding |
|
@bflad of course! |
|
Going to pull in #135 and cut a release this afternoon 👍 |
|
Commits pulled in via #135 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates action.yml to use node20 and while we are here, perform minor dependency updates to resolve any vulnerabilities.
This also now imports nock-beta which includes experimental support for fetch. This was necessary to get the existing tests passing as mocked API calls were not being intercepted correctly. See: nock/nock#2397