Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support react v0.14 #58

Merged
merged 2 commits into from Oct 17, 2015
Merged

Support react v0.14 #58

merged 2 commits into from Oct 17, 2015

Conversation

minimal
Copy link
Contributor

@minimal minimal commented Oct 16, 2015

Hi , this adds minimal support for react 0.14 without affecting 0.13 users.

React 0.14 removes React.initializeTouchEvents as it's no longer
needed.

_isReactElement was removed and replaced with the $$typeof field which
contains an ES6 symbol if supported or a number.

Warnings are visible for 0.14 which could be stopped by using ReactDOM for the
render and findDOMNode functions etc.

https://facebook.github.io/react/blog/2015/10/07/react-v0.14.html#breaking-changes
facebook/react#4832

Adds minimal support for react 0.14 without affecting 0.13 users.

React 0.14 removes React.initializeTouchEvents as it's no longer
needed.

_isReactElement was removed and replaced with the $$typeof field which
contains an ES6 symbol if supported or a number.

Warnings are visible for 0.14 which can be stopped by using ReactDOM for
render and findDOMNode etc.

https://facebook.github.io/react/blog/2015/10/07/react-v0.14.html#breaking-changes
facebook/react#4832
Symbol.for causes:

"WARNING - Keywords and reserved words are not allowed as unquoted
property names in older versions of JavaScript."
@minimal
Copy link
Contributor Author

minimal commented Oct 17, 2015

You were right, I needed to quote $$typeof for advanced to work (as well as adding another extern for react from here). I also quoted the for attribute as the Closure compiler gave warnings about it. I used aget for consistency although I gather goog.object.get is now the recommended way for getting attributes.

An advanced compiled devcards/om.next/react-0.14 page is at http://minimal.github.io/om-next-tut/#!/om_next_tut.core

bhauman pushed a commit that referenced this pull request Oct 17, 2015
@bhauman bhauman merged commit 0020fbc into bhauman:master Oct 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants