Warn about lein trampoline being broken on Windows #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm of the mind to simply not automatically trampoline on Windows. |
bhauman
pushed a commit
that referenced
this pull request
May 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #682.
I've tested this locally on my project, in Windows. With trampoline being invoked I see this warning and the corresponding breakage. With
:readline falseI do not see this warning and nor do I see breakage.I have not tested this on other OSs.
One consideration is whether there are Windows users who have found some other workaround for this issue and who would be annoyed by the banner. I don't know if that's the case - but weighing up an annoyance for some vs incomprehensible breakage for others...I think I personally care more about the latter.