New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Round position in pad() #1

Merged

bibinhashley merged 2 commits into bibinhashley:ImageOps.contain-function-issue-in-finding-new-size from radarhere:ImageOps.contain-function-issue-in-finding-new-size

Aug 30, 2022

radarhere commented Aug 24, 2022 •

edited

Two suggestions for python-pillow#6522

I've added a test for your existing change. Tests are helpful to prevent us accidentally reverting your change in the future.
If we're applying rounding in contain(), why not in pad() as well?

radarhere added 2 commits

August 24, 2022 22:32


          Added test

df4bb34


          Round position in pad()

f9d3ee0

radarhere changed the title ~~Added test~~ Round position in pad()

radarhere mentioned this pull request

Use rounding in ImageOps contain() and pad() python-pillow/Pillow#6522

Merged

bibinhashley merged commit cf4017b into bibinhashley:ImageOps.contain-function-issue-in-finding-new-size

radarhere deleted the ImageOps.contain-function-issue-in-finding-new-size branch

August 30, 2022 12:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment