Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when duplicating #20200

Closed
yakovetsrr opened this issue May 8, 2024 · 4 comments
Closed

Bug when duplicating #20200

yakovetsrr opened this issue May 8, 2024 · 4 comments
Assignees
Milestone

Comments

@yakovetsrr
Copy link

Describe the bug
It's not clear how duplication works on the board when drawing. Logically, duplication should bifurcate one line or replace copy+paste with a single action, but in this case you need to select the area of duplication. Now that duplication is clamped, a huge number of lines are inexplicably duplicated on the board.

Steps to reproduce the behavior:
First scenario

  1. Join the conference
  2. Start drawing on the board
  3. Hold Ctrl+D and continue drawing
  4. As a result, the lines will be duplicated until the number of marks is exceeded.

Second scenario

  1. Join the conference
  2. Start drawing on the board
  3. Hold Ctrl+D and continue drawing
  4. Stop drawing, but don’t let go of Ctrl+D
  5. As a result, the lines will be duplicated until the number of marks is exceeded.

Expected behavior
I expect that when duplicating 1 line will bifurcate and repeat the first line or duplicate the selected area

Actual behavior
Described in "Describe the bug"

Screenshots
Снимок экрана от 2024-05-07 21-26-59

BBB version:
Current version 2.7.7

Desktop:

  • OS: Debian
  • Browser Chrome
  • Version 124.0.6367.91
@KDSBrowne
Copy link
Collaborator

KDSBrowne commented May 9, 2024

This duplication bug with Ctrl+D while drawing lines in bbb 2.7.7 is due to how tldraw in version 1.0 handles it's events. It was fixed in tldraw 2.0 and pulled in bbb 3.0, where Ctrl+D only duplicates selected shapes, not lines in progress.
This avoids the unintended duplications when drawing lines while holding down the shortcut key.

@Wladimir-N
Copy link

This duplication bug with Ctrl+D while drawing lines in bbb 2.7.7 is due to how tldraw in version 1.0 handles it's events. It was fixed in tldraw 2.0 and pulled in bbb 3.0, where Ctrl+D only duplicates selected shapes, not lines in progress. This avoids the unintended duplications when drawing lines while holding down the shortcut key.

Only 3 is not stable yet, so we are still on 2.7.7, and students who know about such a bug sometimes try to sabotage classes in this way when they give everyone the right to draw on the board.

Well, I wonder, will this be fixed in 2.7 or is it just time to wait and plan the transition to 3.0?

@Wladimir-N
Copy link

How can I apply this change before release? In 2.7.7

@Wladimir-N
Copy link

I assembled the package and installed it for production. For some reason he messed up the domain settings, but I set them again and corrected the websocket proxy settings. And everything works great.
There is really one drawback, although it is not clear whether this is a problem.
If you select an object and hold down Ctrl+D, it will be duplicated until it falls within the limit on the number of annotations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants