Add workflow to compute Hasura permission diff using Metadelta #19716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this contribution! Could you please confirm if you already sent in the signed Contributor License Agreement? See https://docs.bigbluebutton.org/support/faq.html#why-do-i-need-to-sign-a-contributor-license-agreement-to-contribute-source-code Thanks in advance! |
silky
changed the title
|
Yes I've signed the CLA. |
|
Thank you very much for this contribution! The CLA was received too! |
silky
force-pushed
the
metadelta-diff-action
branch
from
e92a63f
to
e0c47a1
Compare
|
I've simplified this PR now to use the new GitHub Action - https://github.com/marketplace/actions/hasura-permission-diff-with-metadelta - instead of hard-coding the workflow :) |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Hello :)
I've built a (free for open-source) tool to help out with Hasura permission changes. In developing it, I found this repository as a big user of Hasura.
So, I thought I'd make a PR to add an automatic step to compute a permission diff, following the guide - https://invariant.club/guides/getting-started-with-metadelta.html.
This doesn't address any particular issue on the repo, and I won't be offended if you ignore it, but I thought I'd prepare this PR anyway, in case you would like to try it out!
Motivation
This repo uses Hasura extenstively, and in particular has frequent hasura-related permission changes that are (probably) hard to review from the source-code changes alone.
More
It'd be extremely valuable for me to get feedback on the tool I've built; and in particular any features you may want/think are missing.
Please let me know! I'm always happy to chat and can be reached via the email on my GitHub profile :)