Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Black circle while webcam is connecting in 3.0 #19883

Open
wants to merge 3 commits into
base: v3.0.x-release
Choose a base branch
from

Conversation

Scroody
Copy link
Collaborator

@Scroody Scroody commented Mar 22, 2024

What does this PR do?

This PR fixes a webcam loading/connecting issue, where a black circle was rendering in the user avatar's place.

@ramonlsouza ramonlsouza added this to the Release 3.0 milestone Mar 22, 2024
Copy link

sonarcloud bot commented Apr 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@antonbsa
Copy link
Member

The failed test (Webcam › Pinning and unpinning webcams) doesn't say much about what is the real issue, but I've been trying locally and I'm able to reproduce consistently the bug. What happens is that some users start sharing the webcam but it keeps with the "connecting" status for some others, as they haven't started sharing it. Manually testing I could reproduce by:

  • Joining 1 moderator and 6 attendees;
  • After everyone finished joining (waiting and closing the audio modal as well), I shared the mod webcam;
  • Then I started sharing the attendees' webcam one by one;

Keeping the moderator window visible, I could see some webcam elements showing up but without the video content:
(1. not sure if the error log is related to the bug, but it seems so; 2. the window on the right is from an attendee, who also got a webcam item with the placeholder only)
image

The CI test result shows a similar behavior:
image


When I first tried to reproduce, everything went right. So I forced more CPU usage by increasing the workers' number to run X times the same test simultaneously => npm test webcam -- --workers 6 --project chromium -g "pin" --repeat-each 6.

Running this command, I could easily reproduce the bug, which manually sometimes wasn't so consistent.

Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Automated tests Summary

All the CI tests have passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants