Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Inactivity/activity checks #19930

Open
wants to merge 5 commits into
base: v3.0.x-release
Choose a base branch
from

Conversation

gabriellpr
Copy link
Collaborator

What does this PR do?

Implements the inactivity and activity tests of the user.

@antobinary antobinary added this to the Release 3.0 milestone Mar 28, 2024
Copy link

sonarcloud bot commented Mar 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Automated tests Summary

All the CI tests have passed!

@antonbsa
Copy link
Member

antonbsa commented Apr 5, 2024

I'd suggest not adding the test as is now due to:

  • Without manually enabling this feature, the test will always fail (disabled by default) - which is not good for CI env, for example;
  • Currently, there's no way of getting the userInactivityCheck enabled/disabled value by the frontend (playwright);
  • No create/join parameter for this provided;
  • In case of setting this directly on bbb-web we'd need to restart the application to apply it, which needs an entire implementation of handling settings by the automated tests - this is in our roadmap, but needs to be done before adding this test IMO;

Copy link

github-actions bot commented May 9, 2024

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants