Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webcam): fixes, improvements et al. #20191

Conversation

JoVictorNunes
Copy link
Collaborator

What does this PR do?

This pull request contains a few fixes along with improvements and support for users to open webcams across multiple browser tabs.

  • 096f14e: stop using mapped fields, improving maintainability.
  • 8acdd95: don't return on video-streams subscription error. Let the likely data cleanup happen.
  • 9fcb83b: make the function reactive.
  • 4391b3d: remove remaining video-streams collection usage.
  • e459dcd, 7cb9eae and 728c476: improvements.
  • 429c9ba: removal.
  • 41d70b3: @gustavotrott is working on a cool feature for users to split their session across multiple browser tabs. In order for that to work on the webcam side, we are adding a tabId to video stream IDs, so we can identify every video stream in a unique way.

Closes Issue(s)

None

@antobinary antobinary added this to the Release 3.0 milestone May 9, 2024
@JoVictorNunes JoVictorNunes force-pushed the video-streams-improvements-05.06 branch from ad33173 to 728c476 Compare May 14, 2024 18:00
Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.3% Duplication on New Code

See analysis details on SonarCloud

Copy link

Automated tests Summary

All the CI tests have passed!

@ramonlsouza ramonlsouza requested a review from antonbsa May 22, 2024 18:07
@gustavotrott gustavotrott merged commit 684fec7 into bigbluebutton:v3.0.x-release May 24, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants