Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): add loaders for dynamic menu items #20203

Merged

Conversation

JoVictorNunes
Copy link
Collaborator

@JoVictorNunes JoVictorNunes commented May 9, 2024

What does this PR do?

Adds loaders for dynamic menu items in the chat menu to avoid layout shift and fetchs data from core hooks to speed up the loading.

Screenshot from 2024-05-09 09-54-45

Closes Issue(s)

None

@antobinary antobinary added this to the Release 3.0 milestone May 9, 2024
Copy link
Member

@ramonlsouza ramonlsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check these warnings:
Screenshot from 2024-05-16 16-44-59
Screenshot from 2024-05-16 16-45-13
Screenshot from 2024-05-16 16-45-21

Copy link

sonarcloud bot commented May 20, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Automated tests Summary

All the CI tests have passed!

@ramonlsouza ramonlsouza merged commit 3a015e1 into bigbluebutton:v3.0.x-release May 20, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants