Client: Updating: userdata-bbb_multi_user_tools, userdata-bbb_presenter_tools and userdata-bbb_multi_user_pen_only #20218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er_tools and userdata-bbb_multi_user_pen_only
|
This pull request has conflicts ☹ |
antobinary
reviewed
May 14, 2024
bigbluebutton-html5/imports/ui/components/whiteboard/component.jsx
Outdated
Show resolved
Hide resolved
antobinary
reviewed
May 14, 2024
antobinary
reviewed
May 14, 2024
antobinary
reviewed
May 14, 2024
antobinary
reviewed
May 14, 2024
Co-authored-by: Anton Georgiev <antobinary@users.noreply.github.com>
Co-authored-by: Anton Georgiev <antobinary@users.noreply.github.com>
Co-authored-by: Anton Georgiev <antobinary@users.noreply.github.com>
Co-authored-by: Anton Georgiev <antobinary@users.noreply.github.com>
|
Automated tests Summary✅ All the CI tests have passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR addresses the bug related to the adaptation of passable join parameters userdata-bbb_presenter_tools= and userdata-bbb_multi_user_tools= to tldraw in BBB 3.0. The listed parameters were not functioning as expected in tldraw, leading to the issue described in ticket #16168. The following steps were taken to fix the issue:
Adapted the code in bbb-html5 to support tldraw names of tools.
Confirmed that userdata-bbb_multi_user_pen_only is functioning again (api mate).
Confirmed that userdata-bbb_presenter_tools= is functioning again (api mate).
Confirmed that userdata-bbb_multi_user_tools= is functioning again (api mate).
Adapted the documentation in customize.md to provide a clear description of userdata-bbb_multi_user_tools= and userdata-bbb_multi_user_pen_only, including a full list of accepted parameters and an example of the syntax.
Changes Made
Updated bbb-html5 code to support tldraw names of tools.
Ensured functionality of userdata-bbb_multi_user_pen_only.
Ensured functionality of userdata-bbb_presenter_tools=.
Ensured functionality of userdata-bbb_multi_user_tools=.
Adapted documentation in customize.md to reflect changes and provide clear instructions.
Closes Issue(s)
#19961
Motivation
The motivation behind this issues and PR was that none of the parameters were functioning as they were initially intended to, due to changes made over the time in the BBB whiteboard.