Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): disable jsx-a11y/no-onchange #53

Merged
merged 1 commit into from Jul 6, 2021
Merged

fix(config): disable jsx-a11y/no-onchange #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/eslint-config/configs/react.js
View file
Open in desktop
Expand Up @@ -11,6 +11,8 @@ module.exports = {
},
plugins: ['react-hooks'],
rules: {
// Remove when https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/pull/757 gets released
'jsx-a11y/no-onchange': 'off',
Comment on lines +14 to +15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iirc eslint will complain with a non existing rule...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rule still exists, just got deprecated from the recommended config.

Copy link
Contributor

@icatalina icatalina Jul 6, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant when they delete the rule, will find out... not sure we needed the coment 😅

'react-hooks/exhaustive-deps': 'error',
'react-hooks/rules-of-hooks': 'error',
'react/destructuring-assignment': 'error',
Expand Down
12 changes: 6 additions & 6 deletions packages/eslint-config/test/__snapshots__/eslint.spec.js.snap
View file
Open in desktop
Expand Up @@ -841,7 +841,7 @@ Object {
},
],
"jsx-a11y/no-onchange": Array [
"error",
"off",
],
"jsx-a11y/no-redundant-roles": Array [
"error",
Expand Down Expand Up @@ -2788,7 +2788,7 @@ Object {
},
],
"jsx-a11y/no-onchange": Array [
"error",
"off",
],
"jsx-a11y/no-redundant-roles": Array [
"error",
Expand Down Expand Up @@ -4574,7 +4574,7 @@ Object {
},
],
"jsx-a11y/no-onchange": Array [
"error",
"off",
],
"jsx-a11y/no-redundant-roles": Array [
"error",
Expand Down Expand Up @@ -6359,7 +6359,7 @@ Object {
},
],
"jsx-a11y/no-onchange": Array [
"error",
"off",
],
"jsx-a11y/no-redundant-roles": Array [
"error",
Expand Down Expand Up @@ -8409,7 +8409,7 @@ Object {
},
],
"jsx-a11y/no-onchange": Array [
"error",
"off",
],
"jsx-a11y/no-redundant-roles": Array [
"error",
Expand Down Expand Up @@ -10511,7 +10511,7 @@ Object {
},
],
"jsx-a11y/no-onchange": Array [
"error",
"off",
],
"jsx-a11y/no-redundant-roles": Array [
"error",
Expand Down