Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax required ruby version #140

Closed
wants to merge 2 commits into from

Conversation

such
Copy link

@such such commented Dec 29, 2021

What? Why?

Ruby 3.1 was released.
I used no max version, the same way Rails does (amongst others).

How was it tested?

Ran rspec with ruby 3.1

@splittingred
Copy link
Member

Hey @such - thanks! While I can test and run this fine locally, we require CircleCI tests for each ruby version (see .circleci/config.yml), and this would also need to update the README and CHANGELOG appropriately to adjust the supported versions.

I believe there's an outstanding issue with Ruby 3.1 and bundler and the core grpc gem that causes OOMs on install in CircleCI, due to CCI using bundler 2.3.3 (which had a packaging issue that resulted in the runtime being broken there). We may have to wait until CCI updates their ruby 3.1 image to bundler 2.3.4 before proceeding. They're typically fairly fast so I'd expect that within a week or so.

@such
Copy link
Author

such commented Jan 3, 2022

Hey @splittingred.
Thank you for the feedback! I'll make those changes!

In the meantime, I'm also having issues with my ruby 3.1 docker image... Can you point me to a thread that talks about this? Do you know if the issue is specific to grpc?

@splittingred
Copy link
Member

@such I believe the CCI issue is related grpc not having pre-built binaries for Ruby 3.1, causing it to have to compile at install time (which makes the gemset huge for one).

See grpc/grpc#28627

Also, google-protobuf does not yet support Ruby 3.1:

protocolbuffers/protobuf#9364

@splittingred
Copy link
Member

Hello @such ! I've opened #150 to get this to work; though it's noted that grpc/grpc#28627 is still an issue, so initial uncached installations of the grpc gem will take a long time.

However, this passes tests and end-to-end suites, so we're good to allow it in gruf now.

@splittingred
Copy link
Member

This has been merged in #150 - closing this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants