Add Rails Integration #161
Open
+206
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlyaChizhanov
force-pushed
the
rails_integration
branch
2 times, most recently
from
89d16bd
to
7f96b94
Compare
IlyaChizhanov
force-pushed
the
rails_integration
branch
from
7f96b94
to
54c0d32
Compare
|
@IlyaChizhanov Thanks for the suggestion! I'm a bit concerned with doing this, as this changes the core operating model of gruf, and runs it in a way separate from its original intent. This would be a breaking (major) change, and I'd rather keep gruf separate from the runtime model of rails. That said, this sounds like an excellent candidate for a gruf-rails gem, which could offer an alternative operating model, one more embedded like ActionCable or other systems. I'd take that path instead. |
IlyaChizhanov
commented
Jul 20, 2022
| @@ -89,31 +86,55 @@ def server | |||
| # Start the gRPC server | |||
| # | |||
| # :nocov: | |||
| def start! | |||
| update_proc_title(:starting) | |||
| def start | |||
There was a problem hiding this comment.
@splittingred I can try to create this gem, but in any case, I need changes in this part so as not to cause blocking of the main thread.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Hi. I added integration with Rails(since 6.1) based on AnyCable.
Now there is no need to call
bundle exec gruf.I had to change the structure of the startup logic a lot, but I hope I didn't break anything.
How was it tested?
For testing, I used a demo project and tests.