Clone volume #526

lehecht · 2022-12-09T13:46:45Z

Cloning files and their (annotation) labels is optional now
FormRequest is used for request validation

mzur

There are two bigger points that I raise in the review comments:

The API might be easier to use if you copy all images by default (if no file IDs are given). The same could be done for annotations and file labels (with a additional boolean parameters).
The file_label_ids and label_ids should be the IDs of the labels table and not the image_labels or image_annotation_labels table (which both have the label IDs as label_id foreign key).

Also, you should add some test cases for the new behavior.

app/Http/Controllers/Api/VolumeController.php

app/Http/Requests/CloneVolume.php

package-lock.json

Bumps [symfony/http-kernel](https://github.com/symfony/http-kernel) from 6.0.16 to 6.0.20. - [Release notes](https://github.com/symfony/http-kernel/releases) - [Changelog](https://github.com/symfony/http-kernel/blob/6.2/CHANGELOG.md) - [Commits](symfony/http-kernel@v6.0.16...v6.0.20) --- updated-dependencies: - dependency-name: symfony/http-kernel dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

…/http-kernel-6.0.20 Bump symfony/http-kernel from 6.0.16 to 6.0.20

Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/kornelski/http-cache-semantics/releases) - [Commits](https://github.com/kornelski/http-cache-semantics/commits) --- updated-dependencies: - dependency-name: http-cache-semantics dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

…p-cache-semantics-4.1.1 Bump http-cache-semantics from 4.1.0 to 4.1.1

mzur

Almost finished 👍

Please also add the two @psalm-suppress comments to the final changes.

app/Jobs/CloneImagesOrVideos.php

routes/web.php

tests/php/Http/Controllers/Api/VolumeControllerTest.php

tests/php/Jobs/CloneImagesOrVideosTest.php

mzur · 2023-02-20T08:37:19Z

The maintainer of the PHP linter Psalm was very quick with a fix for the issue that you discovered. I've updated the dependency in your branch. There is no need for the @psalm-suppress comments any more.

mzur

Only one thing slipped through. Then everything is ready to be merged.

routes/web.php

mzur

👍

lehecht added 26 commits December 1, 2022 17:06

clone only subsets of volume content

b331d31

add data to post requests

8e9d189

merge cloneVolume with optionalFeature branch

d5c3559

adapt api parameter names

91ba715

add label id filter function

89ec723

remove redundant empty array check for images

25a6aa2

remove redundant empty array check for videos

6a08d3f

cast filtered collections to array

3be9e09

copy imageLabels by using a label id array

7b18de4

copy videoLabels by using a label id array

025aebf

merge clone-volume

fa8ce7a

replace post() by postJson()

f03a89e

clone image annotations and labels selectively

28edfa7

clone video annotations and labels selectively

a13dc5f

create incomplete cloneVolume FromRequest class

cd8cdcb

replace authorization by using FromRequest class

7a6b1fe

include volume in authorize()

8e3304a

add async job dispatch

ca6715c

move file cloning methods to job class

67210d3

create job class for async file cloning

4a7d3c6

add validator for arrays

f8462a2

catch id not found exceptions

ac977b8

add comments

789b0c7

fix wrong type in javadoc

fd93880

merge cloneVolume

9c896c5

call ProcessNewVolumeFiles for every file

1656fea

mzur requested changes Dec 12, 2022

View reviewed changes

mzur reviewed Dec 12, 2022

View reviewed changes

package-lock.json Outdated Show resolved Hide resolved

lehecht added 2 commits January 2, 2023 17:26

use request to get the project and volume

f8a884a

add more api parameter to simplify cloning process

9d0c47f

lehecht and others added 14 commits February 1, 2023 18:57

delete parameter type due to failing tests

eec3534

change back CloneVolume to Request

4ecb527

Merge pull request biigle#540 from biigle/dependabot/composer/symfony…

16de585

…/http-kernel-6.0.20 Bump symfony/http-kernel from 6.0.16 to 6.0.20

Upgrade PHP dependencies

5bfc625

Merge pull request biigle#541 from biigle/dependabot/npm_and_yarn/htt…

2c9c3a1

…p-cache-semantics-4.1.1 Bump http-cache-semantics from 4.1.0 to 4.1.1

add annotation thumbnail creation methods

17f400f

add tests for annotation thumbnail creation

7b042c0

process new files and annotations

5063b61

Merge branch 'cloneVolume' into clone-volume

b0fe3aa

Specify PHP 8.1 in lint workflow and composer.json

e98ddb3

Fix Psalm error

c08a759

Fix composer.json and composer.lock

c71b846

mzur requested changes Feb 17, 2023

View reviewed changes

lehecht and others added 8 commits February 18, 2023 13:57

add @psalm-supppress due to the bug

3cfdaab

move method of file annotation thumbnail creation

1884ae0

fix wrong import

4a054ea

move tests for file annotation thumbnail creation

04d3952

remove unnecessary requests

c5c7dfe

Upgrade Psalm

328d881

Update Psalm config

f1687c9

Merge branch 'master' into lehecht-clone-volume

32477f1

lehecht added 2 commits February 20, 2023 15:16

remove psalm supress annotation

520f01c

Merge branch 'cloneVolume' into clone-volume

c5549cc

mzur requested changes Feb 21, 2023

View reviewed changes

routes/web.php Outdated Show resolved Hide resolved

remove route

4ca666d

mzur approved these changes Feb 21, 2023

View reviewed changes

mzur merged commit 3e11bec into biigle:clone-volume Feb 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clone volume #526

Clone volume #526

lehecht commented Dec 9, 2022

mzur left a comment

mzur left a comment •

edited

mzur commented Feb 20, 2023 •

edited

mzur left a comment

mzur left a comment

Clone volume #526

Clone volume #526

Conversation

lehecht commented Dec 9, 2022

mzur left a comment

Choose a reason for hiding this comment

mzur left a comment • edited

Choose a reason for hiding this comment

mzur commented Feb 20, 2023 • edited

mzur left a comment

Choose a reason for hiding this comment

mzur left a comment

Choose a reason for hiding this comment

mzur left a comment •

edited

mzur commented Feb 20, 2023 •

edited