Return permissions error directly #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeladda
approved these changes
Nov 11, 2017
| @@ -123,7 +123,7 @@ | |||
| steps: | |||
| - in: bn init -p /home/dockeruser/test/securedir | |||
| out: |- | |||
| bn: Permission denied writing to path: /home/dockeruser/test/securedir* | |||
| bn: EACCES: permission denied, unlink '/home/dockeruser/test/securedir/function.js' | |||
There was a problem hiding this comment.
why is the first privileged operation we do unlink?
There was a problem hiding this comment.
To copy our template function.js file to the users function directory we use the copy method in fs-extra. Looking at the source code here I can see that they use fs.unlink to ensure that there is no other file handle in the location where the user wants the file copied.
Funny enough here's an issue currently in progress to replace unlink with rename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided that we wouldn't wrap unixy errors ourselves.