fix: add handling for errors in fetchUser (#25)

* fix: add handling for errors in fetchUser * Update src/utils/fetchUser.ts Co-authored-by: pat <73502164+nyapat@users.noreply.github.com> Co-authored-by: tOwOgarashi <togarashi@togarashi.owoowowowowowoowowowowo> Co-authored-by: pat <73502164+nyapat@users.noreply.github.com>
binarysus · Aug 10, 2021 · ddb2bbb · ddb2bbb
1 parent 4524fea
commit ddb2bbb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/src/commands/general/profile.ts b/src/commands/general/profile.ts
@@ -16,8 +16,8 @@ const command: Command = {
   ],
   permissions: [],
   async execute(interaction) {
-    const value = interaction.options.get("user")?.value;
-    const data = await fetchUser(value as string);
+    const value = interaction.options.getString("user", true);
+    const data = await fetchUser(value);
     if(!data) {
       interaction.reply({ content: PROFILE_NOT_FOUND, ephemeral: true });
     }

diff --git a/src/utils/fetchUser.ts b/src/utils/fetchUser.ts
@@ -3,9 +3,8 @@ import { BINARYSEARCH_API } from "#constants/urls";
 import type { BSUser } from "#types/BSUser";
 
 export async function fetchUser(username: string): Promise<null | BSUser> {
-  const url = BINARYSEARCH_API.replace("USERNAME", username);
-  const data = await fetch(url).then(res => res.json());
+  const url = BINARYSEARCH_API.replace("USERNAME", encodeURIComponent(username));
+  const data = await fetch(url).then(res => res.json()).catch(console.error);
 
-  if ("user" in data) return data.user;
-  return null;
+  return data?.user ?? null;
 }