Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Deny OOM, embrace try_reserve #448

Open
wants to merge 13 commits into
base: trunk
Choose a base branch
from
Open

[WIP] Deny OOM, embrace try_reserve #448

wants to merge 13 commits into from

Commits on Mar 17, 2024

  1. Added a pipeline to deny 'no_global_oom_handling' 

    Added try_reserve to VecWriter, Vec, VecDeque and HashMap
Made the OOM test succeed on the latest nightly
Made the OOM check work on nightly
Disabled stable checks for now
Removed feature that is stable in current nightly
Fixed issue where Box<[T]> would not do the size limit check
Added a drop guard to `impl<T> Decode for Vec<T>` to make sure memory is not leaked when T::Decode panics
Made the implementation of `VecWriter` use less lines of unsfe
Fixed errors while merging
    @VictorKoenders
    VictorKoenders authored and Victor Koenders committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    b77d9ea View commit details
    Browse the repository at this point in the history

  2. Fixed CI issues

    @VictorKoenders
    VictorKoenders authored and Victor Koenders committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    07b2702 View commit details
    Browse the repository at this point in the history

  3. Moved OOM to it's own CI file and added a MIRI step

    @VictorKoenders
    VictorKoenders authored and Victor Koenders committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    1d2a0b0 View commit details
    Browse the repository at this point in the history

  4. Fixed clippy lint

    @VictorKoenders
    VictorKoenders authored and Victor Koenders committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    740c5ee View commit details
    Browse the repository at this point in the history

  5. Attempt at fixing MIRI CI

    @VictorKoenders
    VictorKoenders authored and Victor Koenders committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    cfcc4f8 View commit details
    Browse the repository at this point in the history

  6. Made miri ignore tempfile::tempfile()

    @VictorKoenders
    VictorKoenders authored and Victor Koenders committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    93c02c1 View commit details
    Browse the repository at this point in the history

  7. Disabled test_std_file when running on miri as ignoring the tempfile … 

    …did not fix the runtime error
    @VictorKoenders
    VictorKoenders authored and Victor Koenders committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    2b4677a View commit details
    Browse the repository at this point in the history

  8. Disabled test_std_file proper now (I hope)

    @VictorKoenders
    VictorKoenders authored and Victor Koenders committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    c96ac68 View commit details
    Browse the repository at this point in the history

  9. Fixed warning and errors while running unstable-strict-oom-checks

    @VictorKoenders
    VictorKoenders authored and Victor Koenders committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    680ca6d View commit details
    Browse the repository at this point in the history

  10. Small improvements, added documentation about the new feature

    Victor Koenders authored and Victor Koenders committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    36eea25 View commit details
    Browse the repository at this point in the history

  11. Fixed a possible fallible allocation issue

    Victor Koenders committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    735e175 View commit details
    Browse the repository at this point in the history

  12. Fixed some warnings

    Victor Koenders committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    e44d7c1 View commit details
    Browse the repository at this point in the history

  13. Fixed compilation issues

    Victor Koenders committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    c4e11a1 View commit details
    Browse the repository at this point in the history