Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading to slf4j2 #1094

Merged
merged 3 commits into from May 22, 2024
Merged

Upgrading to slf4j2 #1094

merged 3 commits into from May 22, 2024

Conversation

josemduarte
Copy link
Contributor

As subject says

JonStargaryen
JonStargaryen approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@JonStargaryen JonStargaryen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Because it's nearby in the code: Do we have a plan for the MMTF deprecation? The codec is still useful once mmtf.rcsb.org stops serving data but could also get rid of it.

@josemduarte
Copy link
Contributor Author

Because it's nearby in the code: Do we have a plan for the MMTF deprecation? The codec is still useful once mmtf.rcsb.org stops serving data but could also get rid of it.

Yes the codec is still useful, so in principle it is a good idea to keep for a while longer. I would not want it to stay too long though, because there's not much maintenance on the mmtf codec java libs.

@josemduarte josemduarte merged commit 50ac975 into biojava:master May 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonStargaryen JonStargaryen JonStargaryen approved these changes

@heuermh heuermh Awaiting requested review from heuermh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@josemduarte @JonStargaryen