Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃摑 Comment's above the from 'blah' in a multi-line-export do not have whitespace preserved, moved to same line as from #1589

Closed
1 task done
SpanishPear opened this issue Jan 18, 2024 · 4 comments 路 Fixed by #1603
Closed
1 task done

馃摑 Comment's above the from 'blah' in a multi-line-export do not have whitespace preserved, moved to same line as from #1589

SpanishPear opened this issue Jan 18, 2024 · 4 comments 路 Fixed by #1603
Labels
A-Formatter Area: formatter S-Bug-confirmed Status: report has been confirmed as a valid bug S-Help-wanted Status: you're familiar with the code base and want to help the project

Comments

@SpanishPear
Copy link
Contributor

Environment information

N/A - Playground

Configuration

No response

Playground link

https://biomejs.dev/playground/?code=ZQB4AHAAbwByAHQAIAB7AAoAIAAgACAAIABUAEUAUwBUACwACgAgACAAIAAgAFMATwBNAEUALAAKACAAIAAgACAARQBYAFAATwBSAFQAUwAsAAoAIAAgACAAIAAvAC8AIABlAHMAbABpAG4AdAAtAGQAaQBzAGEAYgBsAGUALQBuAGUAeAB0AC0AbABpAG4AZQAgAHMAbwBtAGUALwBjAHUAcwB0AG8AbQAvAHIAdQBsAGUACgB9ACAAZgByAG8AbQAgACcAcwBvAG0AZQAtAHAAYQBjAGsAYQBnAGUAJwA7AA%3D%3D

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@SpanishPear
Copy link
Contributor Author 

export {
      SOME,
      EXPORTS,
- 路路路路//路eslint-disable-next-line路some/custom/rule
- }路from路'some-package';
+ }路from路//路eslint-disable-next-line路some/custom/rule
+ 'some-package';

Sorry if the title is misleading, hope the playground/diff makes it clear :)

@SpanishPear SpanishPear changed the title 馃摑 Comment's above the from 'blah' in a multi-line-export do not have whitespace preserved 馃摑 Comment's above the from 'blah' in a multi-line-export do not have whitespace preserved, moved to same line as from Jan 18, 2024
@ematipico ematipico added S-Help-wanted Status: you're familiar with the code base and want to help the project A-Formatter Area: formatter S-Bug-confirmed Status: report has been confirmed as a valid bug labels Jan 18, 2024
@SpanishPear
Copy link
Contributor Author

How easy would something like this be? With some guidance I could take a look :D

@ematipico
Copy link
Member

ematipico commented Jan 18, 2024 •
edited

@SpanishPear

You might want to start looking at how/where we place the comments: https://github.com/biomejs/biome/blob/main/crates%2Fbiome_js_formatter%2Fsrc%2Fcomments.rs#L121

Here is an explanation of comments: https://docs.rs/biome_formatter/latest/biome_formatter/comments/index.html

@SpanishPear SpanishPear mentioned this issue Jan 19, 2024
Merged
@SpanishPear
Copy link
Contributor Author

Thanks for your guidance @ematipico !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Formatter Area: formatter S-Bug-confirmed Status: report has been confirmed as a valid bug S-Help-wanted Status: you're familiar with the code base and want to help the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(formatter): correctly handle comments at end of export/import list SpanishPear/biome
2 participants
@ematipico @SpanishPear