Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formatter): correctly handle comments at end of export/import list #1603

Conversation

SpanishPear
Copy link
Contributor

@SpanishPear SpanishPear commented Jan 19, 2024

Summary

Fixes #1589

Happy to receive feedback on the implementation, not sure if there are obvious edge-cases I'm not considering, but it passes the test suite!

Test Plan

Ive added a snapshot from the issue with import/export, and pass the prettier tests

Copy link

netlify bot commented Jan 19, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit c8e3d67
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65ab17e63cd28b000899dc7f
😎 Deploy Preview https://deploy-preview-1603--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages labels Jan 19, 2024
@github-actions github-actions bot added the A-Changelog Area: changelog label Jan 19, 2024
@Conaclos
Copy link
Member

Conaclos commented Jan 19, 2024

Hi! Thanks for your contribution :)

Ci is failing because some Rust files are not formatted and the website was not updated.
You can run just format (just f) and just gen-web to solve these issues.

Copy link

codspeed-hq bot commented Jan 19, 2024

CodSpeed Performance Report

Merging #1603 will not alter performance

⚠️ No base runs were found

Falling back to comparing SpanishPear:spanishpear/formatter_last_line_comment_import_list (c8e3d67) with main (efa2911)

Summary

✅ 93 untouched benchmarks

@github-actions github-actions bot added the A-Website Area: website label Jan 20, 2024
@SpanishPear
Copy link
Contributor Author

Thanks @Conaclos - looks like my editor formatting is broken 😢

Have pushed up those two commits!

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's awesome!

@ematipico ematipico merged commit d853402 into biomejs:main Jan 20, 2024
19 checks passed
ematipico pushed a commit to DaniGuardiola/biome that referenced this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Formatter Area: formatter A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
3 participants