Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useJsxKeyInIterable): unwrap parenthesized expressions #2076

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

Sec-ant
Copy link
Contributor

@Sec-ant Sec-ant commented Mar 13, 2024

Summary

This is a follow-up of #2016 to handle all parenthesized expressions.

See #2011 (comment)

Test Plan

New test cases are added and should pass.

A follow-up of biomejs#2016 to handle all parenthesized expressions
@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Mar 13, 2024
Copy link

netlify bot commented Mar 13, 2024

Deploy Preview for biomejs canceled.

Name Link
🔨 Latest commit 64176dc
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65f16cff9efa8b0008956c92

Copy link

codspeed-hq bot commented Mar 13, 2024

CodSpeed Performance Report

Merging #2076 will not alter performance

⚠️ No base runs were found

Falling back to comparing Sec-ant:fix-use-jsx-key-in-iterable (64176dc) with main (8e8e450)

Summary

✅ 93 untouched benchmarks

@ematipico ematipico merged commit 0a74c02 into biomejs:main Mar 13, 2024
17 checks passed
@Sec-ant Sec-ant deleted the fix-use-jsx-key-in-iterable branch March 13, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants