feat(lint/useExhaustiveDependencies): support Preact #2105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Linter
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
1 task
CodSpeed Performance ReportMerging #2105 will not alter performanceComparing Summary
|
|
Let's hold off the merge of this PR. Let's fix more bugs, ship some more patches, and then merge it :) |
ematipico
approved these changes
Mar 16, 2024
|
You mean you want to do more 1.6.x releases before merging it, right? I’m having trouble saying if it’s tongue-in-cheek 😅 |
|
Yes. If we merge a minor (because it is), we're forced to ship a 1.7.0 |
nstepien
reviewed
Apr 5, 2024
Comment on lines
-271
to
+273
| ### Linter | ||
| ### Parser |
There was a problem hiding this comment.
Why did this change?
| @@ -359,10 +361,6 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b | |||
|
|
|||
| #### Bug fixes | |||
|
|
|||
| - JavaScript lexer is now able to lex regular expression literals with escaped non-ascii chars ([#1941](https://github.com/biomejs/biome/issues/1941)). | |||
|
|
|||
| Contributed by @Sec-ant | |||
There was a problem hiding this comment.
Why was this removed?
Bad merge conflict resolution?
There was a problem hiding this comment.
Ah yes, that was indeed a wrongly merged conflict. I'll fix right away, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This implements support for hooks imported from Preact instead of only React.
I have also checked two other rules:
useHookAtTopLeveluses the naming convention to determine what is a hook, so it should already have been compatible with Preact.noRenderReturnValuechecks that the return value of ReactDOM'srender()function isn't being used. According to Preact's documentation, theirrender()function already doesn't return anything, so I think that hook doesn't apply to Preact.I hope this covers all places where React/Preact compatibility might be relevant for us.
Fixes #2043.
Test Plan
Test case added.