Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(noUndeclaredDependencies): false positives #2128

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

Sec-ant
Copy link
Contributor

@Sec-ant Sec-ant commented Mar 19, 2024

Summary

This PR fixes some false positives reported by the rule noUndeclaredDependencies.

Test Plan

New valid test cases are added.

@github-actions github-actions bot added A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Mar 19, 2024
Copy link

netlify bot commented Mar 19, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit f48ad2e
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65f8f68881333a00077d2fed
😎 Deploy Preview https://deploy-preview-2128--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 92 (🔴 down 7 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codspeed-hq bot commented Mar 19, 2024

CodSpeed Performance Report

Merging #2128 will degrade performances by 6%

⚠️ No base runs were found

Falling back to comparing Sec-ant:fix/no-undeclared-dependencies (f48ad2e) with main (5f60beb)

Summary

❌ 1 regressions
✅ 92 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main Sec-ant:fix/no-undeclared-dependencies Change
big5-added.json[uncached] 2.9 ms 3.1 ms -6%

Copy link
Contributor

@arendjr arendjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@arendjr arendjr merged commit 8df8bd3 into biomejs:main Mar 19, 2024
16 of 18 checks passed
@Sec-ant Sec-ant deleted the fix/no-undeclared-dependencies branch March 19, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
2 participants