Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(json-schema): remove field options for rules without options #2331

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented Apr 6, 2024

Summary

Fix #2313 by completely removing options form the JSON schema for rules without any option.

Test Plan

I manually tested the schema.

@github-actions github-actions bot added A-CLI Area: CLI A-Tooling Area: internal tools A-Website Area: website A-Changelog Area: changelog labels Apr 6, 2024
Copy link

netlify bot commented Apr 6, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 04eb44b
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/66127c439b41770008f0c11c
😎 Deploy Preview https://deploy-preview-2331--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Conaclos Conaclos force-pushed the conaclos/fix-schema-rule-without-options branch 2 times, most recently from e73e9b1 to 9af3af2 Compare April 6, 2024 21:01
Copy link
Contributor

github-actions bot commented Apr 6, 2024

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48721 48721 0
Failed 980 980 0
Panics 0 0 0
Coverage 98.03% 98.03% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 593 593 0
Failed 69 69 0
Panics 0 0 0
Coverage 89.58% 89.58% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13439 13439 0
Failed 4205 4205 0
Panics 2 2 0
Coverage 76.16% 76.16% 0.00%

@Conaclos Conaclos force-pushed the conaclos/fix-schema-rule-without-options branch from 9af3af2 to 737e239 Compare April 6, 2024 21:02
@Conaclos Conaclos changed the title fix(json-schema): remove field options for rules without options fix(json-schema): remove field options for rules without options Apr 6, 2024
Copy link
Member

@SuperchupuDev SuperchupuDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

CHANGELOG.md Outdated Show resolved Hide resolved
@Conaclos Conaclos force-pushed the conaclos/fix-schema-rule-without-options branch from 737e239 to 04eb44b Compare April 7, 2024 10:58
@Conaclos Conaclos merged commit 39b91e9 into main Apr 7, 2024
18 of 19 checks passed
@Conaclos Conaclos deleted the conaclos/fix-schema-rule-without-options branch April 7, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Tooling Area: internal tools A-Website Area: website
Projects
None yet
2 participants