fix(service): allow JSX syntax for javascript
language id
#2376
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow JSX syntax in files with the
javascript
language id.This is an ad hoc fix, because in the React world,
.js
files are allowed to include JSX syntax, and these files are often associated with thejavascript
language identifier in most of the editors. Plus, some editor extensions will also associate.jsx
files with thejavascript
language identifier.And we already allow JSX syntax in
.js
files when running from the CLI. This will make the LSP work more consistently with the CLI.Relative links: discussion, #2085.
Test Plan
Tested locally in the editor with the extension.