Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): support passing file path to --config-path and BIOME_CONFIG_PATH #2419

Merged
merged 5 commits into from
Apr 13, 2024

Conversation

Sec-ant
Copy link
Contributor

@Sec-ant Sec-ant commented Apr 12, 2024

Summary

Test Plan

Added a test case for the 1st feat, and tested manually in VS Code for the 2nd fix.

@github-actions github-actions bot added A-CLI Area: CLI A-Core Area: core A-Project Area: project A-Linter Area: linter A-LSP Area: language server protocol A-Website Area: website L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Apr 12, 2024
Copy link

netlify bot commented Apr 12, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit d8775a5
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/66193fa138ba530007eb1138
😎 Deploy Preview https://deploy-preview-2419--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codspeed-hq bot commented Apr 12, 2024

CodSpeed Performance Report

Merging #2419 will not alter performance

Comparing Sec-ant:feat/config-path (d8775a5) with main (a5242a2)

Summary

✅ 93 untouched benchmarks

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, a lot of significant improvements! Thank you!

Considering that you updated the docs too, what do you think we merge this PR to the release/1.7.0 branch, so the new docs will be published at the release date?

crates/biome_fs/src/fs.rs Show resolved Hide resolved
crates/biome_fs/src/fs.rs Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
crates/biome_cli/src/cli_options.rs Outdated Show resolved Hide resolved
@Sec-ant
Copy link
Contributor Author

Sec-ant commented Apr 12, 2024

Considering that you updated the docs too, what do you think we merge this PR to the release/1.7.0 branch, so the new docs will be published at the release date?

That would be great. But how does that work? Do I need to do something?

@Conaclos Conaclos changed the base branch from main to release/v1.7.0 April 12, 2024 14:23
@Conaclos
Copy link
Member

That would be great. But how does that work? Do I need to do something?

Just changing the base branch of the PR.
I've just done this :)

@ematipico
Copy link
Member

It seems there are a bunch of conflicts. I suggest reverting the change and point that to main again. It's not the end of the world if the docs will stay not synchronized for a few days.

@Sec-ant
Copy link
Contributor Author

Sec-ant commented Apr 12, 2024

I can resolve the conflicts or revert the base to main. Or @Conaclos can do that if he wants. Each is ok by me. But currently I only have my phone around and have to go to bed now.

Please leave a comment to let me know if I should do something and I can address them my time tomorrow.

@Conaclos
Copy link
Member

@Sec-ant Feel free to address them.

@github-actions github-actions bot removed the A-Diagnostic Area: diagnostocis label Apr 13, 2024
@Sec-ant
Copy link
Contributor Author

Sec-ant commented Apr 13, 2024

This branch is rebased on the latest release/v1.7.0

@ematipico ematipico merged commit c960f0e into biomejs:release/v1.7.0 Apr 13, 2024
1 check passed
@Sec-ant Sec-ant deleted the feat/config-path branch April 13, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Core Area: core A-Linter Area: linter A-LSP Area: language server protocol A-Project Area: project A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
3 participants