Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade prettier and update snapshots #2502

Merged
merged 5 commits into from
Apr 30, 2024

Conversation

ah-yu
Copy link
Contributor

@ah-yu ah-yu commented Apr 18, 2024

Summary

Some reformatting issues need to be addressed

Test Plan

CI should pass

@github-actions github-actions bot added A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages labels Apr 18, 2024
Copy link

codspeed-hq bot commented Apr 30, 2024

CodSpeed Performance Report

Merging #2502 will improve performances by 17.73%

Comparing ah-yu:upgrade_prettier (5165a2d) with main (2207d75)

Summary

⚡ 1 improvements
✅ 87 untouched benchmarks

Benchmarks breakdown

Benchmark main ah-yu:upgrade_prettier Change
eucjp.json[uncached] 5.8 ms 4.9 ms +17.73%

@@ -1,5 +0,0 @@
(seventeenfourcharacterssssssssssssssssssssssssssssssssssssssssssssssssssss)=>a?b:c;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test case appears to have been deleted in the prettier repo.

@ah-yu ah-yu marked this pull request as ready for review April 30, 2024 06:15
@ah-yu ah-yu merged commit 520cef0 into biomejs:main Apr 30, 2024
14 checks passed
@ah-yu ah-yu deleted the upgrade_prettier branch April 30, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants