Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint/noUndeclaredVariables): don't report variable-only/type-only exports #2648

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

Conaclos
Copy link
Member

Summary

Fix #2637

When the semantic model finds an export it issues two references: a value reference and a type reference.
Only one reference get resolved when the referenced entity is only a variable (value) or only a type.
The remaining reference is forwarded to the parent scope and eventually marked as unresolved.
This is an erroneous behavior for two reasons:

  1. An export cannot export a variable/type declared in a parent scope.
  2. An export doesn't need to export both a variable and a type.

When we discover an export that exports a type or a variable, we no longer forward and mark as unresolved the dual variable/type.

Test Plan

I added a test.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Apr 29, 2024
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48721 48721 0
Failed 980 980 0
Panics 0 0 0
Coverage 98.03% 98.03% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 593 593 0
Failed 69 69 0
Panics 0 0 0
Coverage 89.58% 89.58% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13439 13439 0
Failed 4205 4205 0
Panics 2 2 0
Coverage 76.16% 76.16% 0.00%

@Conaclos Conaclos merged commit 498dd08 into main Apr 29, 2024
14 checks passed
@Conaclos Conaclos deleted the conaclos/noUndeclaredVariables/2637 branch April 29, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

noUndeclaredVariables complains about default-exported const in .d.ts file
1 participant