Skip to content

Commit

Permalink
Avoid string concatenation and %i formating
Browse files Browse the repository at this point in the history
prank_number is an integer here
  • Loading branch information
peterjc committed Sep 20, 2021
1 parent 763332f commit 7b946db
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions Tests/test_Prank_tool.py
Original file line number Diff line number Diff line change
Expand Up @@ -176,10 +176,7 @@ def conversion(self, prank_number, prank_ext, format):
self.assertEqual(
str(cmdline),
_escape_filename(prank_exe)
+ f" -d={self.input}"
+ f' -o="{self.output}"'
+ " -f=%i" % prank_number
+ " -convert",
+ f' -d={self.input} -o="{self.output}" -f={prank_number} -convert',
)
self.assertEqual(str(eval(repr(cmdline))), str(cmdline))
message, error = cmdline()
Expand Down

0 comments on commit 7b946db

Please sign in to comment.