Add indicator to chat list view about expired messages #2024
Conversation
…al VBox when there are no messages/offers to be shown
|
Sorry I forgot to ask for assignment of this task but since it was a small one I hope I didn't cause annoyance. |
...src/main/java/bisq/desktop/main/content/bisq_easy/offerbook/BisqEasyOfferbookController.java
Outdated
Show resolved
Hide resolved
|
I will add more details to the issue itself to make more clear which approach to use. The style should be less dominant and maybe be similar to the scroll-to-bottom overlay. Maybe @axpoems have some suggestion. See here the scroll-to-bottom overlay. I think a similar approach from design and behaviour would be better. |
djing-chan
changed the title
|
So like something that gets displayed whenever the user reaches the top of the scrolling? |
There was a problem hiding this comment.
NACK
I would use the design style for system messages here. This aligns with the suggestion that @HenrikJannsen was making in the issue, which is to add an entry by default at the beginning.
| if (!isApplicationFocussed && | ||
| isReceivedAfterStartUp(chatNotification) && | ||
| !isExpired(chatNotification)) { |
There was a problem hiding this comment.
This will prevent the system notification to be sent. However, we only send system notifications of messages received while using the app so this seems redundant. Have you tested it?
Also, have you tested that the badge is behaving correctly as well? It shouldn't show the badge number for messages which have expired.
| @@ -72,7 +72,7 @@ public final class BisqEasyOfferbookView extends ChatView<BisqEasyOfferbookView, | |||
| private DropdownTitleMenuItem atLeastTitle; | |||
| private CheckBox hideUserMessagesCheckbox; | |||
| private Label channelHeaderIcon, marketPrice, removeWithOffersFilter, removeFavouritesFilter; | |||
| private HBox appliedFiltersSection, withOffersDisplayHint, onlyFavouritesDisplayHint; | |||
| private HBox appliedFiltersSection, withOffersDisplayHint, onlyFavouritesDisplayHint, expiredMessagesIndicator; | |||
There was a problem hiding this comment.
Why is this only added to the offerbook and not in general to all the chats?
There was a problem hiding this comment.
Note that for private chat messages we do not have an expiry date as its not gossip messages, thus this is not needed. But for common chat messages it should be applied.
| @@ -437,10 +439,15 @@ private void addChatBox() { | |||
| subheader.getStyleClass().add("offerbook-subheader"); | |||
| subheader.setAlignment(Pos.CENTER); | |||
|
|
|||
| Label expiredMessagesIndicatorLabel = new Label(Res.get("bisqEasy.topPane.expiredMessagesIndicator")); | |||
There was a problem hiding this comment.
I see a gap when there's no label:
Changes for issue #1995
Added a check that prevents expired notifications from being sent
Added a HBox (maybe it can be styled better) with a yellow background that is shown when there are no messages/offers