Fix unused-var, shadowed variable warnings and integration test timeouts and descendent chains #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcousens
commented
Jan 6, 2017
src/templates/index.js
Outdated
| @@ -53,7 +53,7 @@ function classifyWitness (script, allowIncomplete) { | |||
| var chunks = decompile(script) | |||
|
|
|||
| if (pubKeyHash.input.check(chunks)) return types.P2WPKH | |||
| if (scriptHash.input.check(chunks)) return types.P2WSH | |||
| if (scriptHash.input.check(chunks, allowIncomplete)) return types.P2WSH | |||
There was a problem hiding this comment.
This... needs tests
|
rebased - will merge if good (may have integration tests fail until #786) |
dcousens
changed the title
|
Merged the test fixes into this as it was frustrating having fixes in both branches. |
|
ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to standard/standard#636 (comment)