Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full tests #75

Merged
merged 102 commits into from Jan 22, 2020
Merged

Full tests #75

merged 102 commits into from Jan 22, 2020

Conversation

davidmarkclements
Copy link

@davidmarkclements davidmarkclements commented Oct 25, 2019

depends on #74

  • refactors tests to use tap (for consistency with mininet tapenet)
  • uses https://npm.im/get-port
    • avoids accidental reliance on hard coded ports
    • avoids port collisions with other running process on machine
    • keeps tests atomic (opened ports are a sort of shared state)
    • elimination of port collisions within each test allows for parelllization which allows for fasting test runs - especially useful when some of the tests have long timeouts
  • uses async test functions, useful for declarative/procedural test code (especially useful with get-port which is promised based)
  • use the https://npm.im/nonsynchronous library for preserving API readability (e.g. using callback based API's as is within an async function so that the tests help to document the APIs)

@davidmarkclements davidmarkclements changed the title Full tests [WIP] Full tests Nov 3, 2019
@davidmarkclements
Copy link
Author

davidmarkclements commented Nov 3, 2019

package.json Outdated Show resolved Hide resolved
lib/Grape.js Outdated Show resolved Hide resolved
Copy link
Contributor

@robertkowalski robertkowalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davidmarkclements davidmarkclements changed the title [WIP] Full tests Full tests Jan 2, 2020
@prdn prdn merged commit 9b85d07 into bitfinexcom:dev Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants