fix: add pdb #1340
Merged
fix: add pdb #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoref
requested review from
alvneiayu,
agarcia-oss and
alemorcuq
as code owners
|
I think you also need to create the template file |
Fixes bitnami-labs#1321 Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
|
Oops, I created it and tested it, but missed a |
|
@jsoref There is always the possibility of using the Just in case, it has been decided not to include every resource in the chart and you happen to need the PDB for your GKE setup |
Signed-off-by: Alvaro Neira Ayuso <alvaron@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Adds an optional PDB to the helm chart
Benefits
Running on GKE would be smoother
Possible drawbacks
Applicable issues
no.scale.down.node.pod.kube.system.unmovablewith helm in default configuration on GKE #1321Additional information
The CI for this repository does not work well in forks and I can't find any documentation on how to update the metadata, so I'm sure people will yell at me.